Author Topic: B2: I love the new "Match Color" checkbox in the find dialog!  (Read 2392 times)

jporkkahtc

  • Senior Community Member
  • Posts: 1795
  • Hero Points: 175
  • Text
B2: I love the new "Match Color" checkbox in the find dialog!
« on: October 07, 2015, 10:23:12 pm »
Thanks - great little feature.

Can you also assign an Alt-? key shortcut to it?
(Looks like "O" isn't already assigned to anything).

Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4819
  • Hero Points: 392
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #1 on: October 07, 2015, 11:17:42 pm »
I had thought about some sort of short cut for this. No one will find/know about an Alt+? short cut. If we use Alt+O, should it be a toggle? and should it display the color dialog when the check box is turned on?

I think it should be a toggle and display the color dialog when the check box is turned on.

Dennis

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2748
  • Hero Points: 420
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #2 on: October 08, 2015, 12:53:57 am »
That's a good idea to show the dialog when it's toggled on, but only if the current color spec is "None".

Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4819
  • Hero Points: 392
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #3 on: October 08, 2015, 12:59:29 am »
I'd prefer getting the quick option to set the colors because I wouldn't mind hitting Esc to dismiss the dialog if I didn't need to change anything.
« Last Edit: October 08, 2015, 01:17:22 am by Clark »

LBCEi

  • Senior Community Member
  • Posts: 182
  • Hero Points: 13
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #4 on: October 08, 2015, 03:42:52 am »
I'm not sure that the current functionality is 'progress' from the previous version where this was a button instead of a checkbox.  It now takes two clicks in separate places to get to the dialog for selecting the types of symbols to search for.  Why the change?

Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4819
  • Hero Points: 392
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #5 on: October 08, 2015, 11:28:01 am »
No convenient way to turn off searching for color. We got complaints about that.

jporkkahtc

  • Senior Community Member
  • Posts: 1795
  • Hero Points: 175
  • Text
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #6 on: October 08, 2015, 04:48:17 pm »
I rarely use MatchColor for anything other than some combination of String and Comment. Usually, find things that aren't strings or comments - code, or find only things that are comments or are strings.

Having a quick way to toggle ColorMatch on and off is great.

I'd rather have the hot-key just do the toggle, and a click on the "..." to change the options is fine -- I like the suggestion from Dennis -- when toggling on, only open the dialog when there are no colors selected.


(Alt-? -- where "?" isn't literally a question mark, but a placeholder for I don't know what key!)

Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4819
  • Hero Points: 392
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #7 on: October 08, 2015, 04:59:56 pm »
If the color dialog only comes up when there are no colors selected color, this won't be useful the color settings are cleared when it's toggled off via the hot key.

jporkkahtc

  • Senior Community Member
  • Posts: 1795
  • Hero Points: 175
  • Text
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #8 on: October 08, 2015, 05:09:14 pm »
If I check "String, comment", it remembers that setting when I toggle the MatchColor checkbox on and off. (Even though it displays "none" when MatchColor is unchecked. Maybe it should always display the setting, but in disabled grey when the checkbox is clear?)

Then, I can always click the "..." to change the specific color options.


Also bug: The MatchColor checkbox is enabled on plain text buffers that have no coloring. MatchColor should be disabled when the "..." is disabled.

jporkkahtc

  • Senior Community Member
  • Posts: 1795
  • Hero Points: 175
  • Text
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #9 on: October 08, 2015, 05:10:29 pm »
Also, clearing the MatchColor checkbox should not disable the "...", rather, when MatchColor is not checked, clicking the "..." should check MatchColor and open the settings dialog.

Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4819
  • Hero Points: 392
Re: B2: I love the new "Match Color" checkbox in the find dialog!
« Reply #10 on: October 08, 2015, 06:03:34 pm »
Also, clearing the MatchColor checkbox should not disable the "...", rather, when MatchColor is not checked, clicking the "..." should check MatchColor and open the settings dialog.

Good idea!