The UI intentionally turns on subfolders if zip is checked.
Well, maybe it does internally, but it doesn't display it.
But this UI state (See the attached) does the wrong thing -- I asked for non-recursive, the UI shows non-recursive, and I still get recursive.
Whatever your opinion on zip archives, doing a plain folder recursive search when "look in subfolders" is unchecked, is a bug.
I'm not sure anyone would expect a non-recursive ZIP search ... though you could make the argument that it is reasonable to treat a ZIP archive the same as any directory.
Seems that 2 check boxes have 4 states and what I would have expected Slick to do:
0. NonRecursive, nonzip: Only files in the LookIn folders - search ZIP files as binary files.
1. NonRecursive, zip: Only files in the LookIn folders, including recursively inside Zip archives
2. Recursive, nonzip: LookIn Folders and children - search ZIP files as binary files.
3. Recursive, Zip: LookIn Folders and children, and inside Zip archives.
Does it ever make sense to search ZIP files as files and not as archives? (Oh, I wish Slick had a option in search "Do not search in binaries" - preferably based on the contents of the file rather than the extension alone. Imagine having that setting and it magically excludes ZIPs as files, object files, executables, dlls, *.gz, etc...)