Author Topic: Top/bottom buffer pushes bookmarks.  (Read 1260 times)

jporkkahtc

  • Senior Community Member
  • Posts: 1787
  • Hero Points: 174
  • Text
Top/bottom buffer pushes bookmarks.
« on: September 07, 2016, 07:50:41 pm »



This pushes a bookmark for each cursor when there are multiple cursors.
Not really useful - unless maybe it would also recreate multiple cursors.


Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4796
  • Hero Points: 388
Re: Top/bottom buffer pushes bookmarks.
« Reply #1 on: September 07, 2016, 09:45:34 pm »
top/bottom of buffer just moves that active cursor. This seems like most useful thing to do. If it moves all the cursors, that would be the same as cancel since cursors may not overlap. Esc seems like a better way to cancel.


jporkkahtc

  • Senior Community Member
  • Posts: 1787
  • Hero Points: 174
  • Text
Re: Top/bottom buffer pushes bookmarks.
« Reply #2 on: September 07, 2016, 10:24:25 pm »
Ok, then the bug is that top/bottom doesn't move just the active cursor.

Repro
Select block
Cursor down several
add-multiple-cursors
Top-of-buffer

Now, it sets several bookmarks - one for each cursor, with only a single cursor at the top of the buffer.

If you move the cursors at all before top-of-buffer then it doesn't do this.


Another repro:
Set multiple cursors with find.
Top-of-buffer
Same thing.

Also, moving the cursors at all before top-of-buffer avoids the problem.

Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4796
  • Hero Points: 388
Re: Top/bottom buffer pushes bookmarks.
« Reply #3 on: September 08, 2016, 12:43:24 pm »
Requires your config for this to happen. Not sure what the difference is yet.

Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4796
  • Hero Points: 388
Re: Top/bottom buffer pushes bookmarks.
« Reply #4 on: September 08, 2016, 12:58:40 pm »
Did you know you turned on def_top_bottom_push_bookmark?

I didn't know we had an option like that. I've tweaked it so it only pushes one bookmark in the multiple cursors situation. I'm not sure if that's the right thing to do. Maybe it shouldn't push any bookmarks.

jporkkahtc

  • Senior Community Member
  • Posts: 1787
  • Hero Points: 174
  • Text
Re: Top/bottom buffer pushes bookmarks.
« Reply #5 on: September 08, 2016, 04:18:07 pm »

Yeah I knew about that option, you didn't? Maybe thats why: https://community.slickedit.com/index.php/topic,11125.msg53003.html#msg53003
isn't fixed. This still happens for SearchResults, I don't know about the other cases - search results is the annoying one for me.
(enable this option, put your cursor in a search results tab, then goto top/bottom: Bookmarks are created on the bookmark stack).



Why does top/bottom sometimes keep multiple cursors and sometimes not?


Clark

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 4796
  • Hero Points: 388
Re: Top/bottom buffer pushes bookmarks.
« Reply #6 on: September 08, 2016, 07:25:02 pm »
Looks like the Top/Bottom buffer pushes bookmark feature wasn't done right in the beginning. If this continues to be problematic, this feature will have to be pulled.