Author Topic: DZ Source Diff & Comments & GREEN highlight  (Read 1021 times)

jporkkahtc

  • Senior Community Member
  • Posts: 1960
  • Hero Points: 185
  • Text
DZ Source Diff & Comments & GREEN highlight
« on: September 13, 2017, 06:58:58 pm »
I realize this could be argued either way - by design as a feature, or a bug, but ...

So if you enable SourceDiff with "Skip all comments", then differences in comments in the right hand file (file #2) are not even displayed nor will they be copied.

Example: Given the two attached filed, do a diff with SourceDiff and SkipAllComments.
The text "(RIGHT ONLY TEXT)" on line 5 is hidden.
The text "# Right side comment only" is also hidden.

But, it is more than just hidden - it is completely not there.
So, on line 8 "Class Stuff", click "<<Block" or "<<Line".
The code difference is moved into xcsv1, but the comment that is also there is lost.

Seems like it ought to copy it over.


Dan

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2456
  • Hero Points: 137
Re: DZ Source Diff & Comments & GREEN highlight
« Reply #1 on: September 13, 2017, 08:14:07 pm »
I will take a look at this, it probably will not make 22.0 at this point.

jporkkahtc

  • Senior Community Member
  • Posts: 1960
  • Hero Points: 185
  • Text
Re: DZ Source Diff & Comments & GREEN highlight
« Reply #2 on: September 13, 2017, 08:18:32 pm »
I had it in the title, but I forgot to complain...

The GREEN color isn't shown in the key at the bottom (where it explains inserted/modified/imaginary).

Is green only used for changes hidden by source diff?
Seems like it also is used for things like whitespace differences.

Dan

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2456
  • Hero Points: 137
Re: DZ Source Diff & Comments & GREEN highlight
« Reply #3 on: September 13, 2017, 08:22:50 pm »
It is only for Source Diff changes, which really are whitespace changes.  You'll never see that color with Source Diff shut off.  It should be added to the legend at the bottom, I'm not sure why we never have.  I'll put that on the list too.