« previous next »
Pages: [1]   Go Down

Author Topic: Files saved in DiffZilla not honoring "strip trailing spaces" setting  (Read 2458 times)

JeffB

  • Senior Community Member
  • Posts: 326
  • Hero Points: 14
Files saved in DiffZilla not honoring "strip trailing spaces" setting
« on: November 30, 2018, 12:16:33 AM »
Open a file in DiffZilla (I used a git diff) that has trailing whitespaces on some lines.  Save the file, and all the eol whitespaces will have been removed.  "Strip trailing spaces" setting is set to "Strip trailing spaces only from modified lines".  Saving from editor works correctly.
(v23 with cumulative1 hotfix)
Logged

Dan

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2897
  • Hero Points: 153
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #1 on: November 30, 2018, 02:58:52 PM »
I will look into this.
Logged

Dan

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2897
  • Hero Points: 153
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #2 on: November 30, 2018, 03:15:24 PM »
I can't reproduce this.  I do see an issue that if the file is modified and you save it in the diff, it actually isn't stripping the trailing spaces (I'm not sure why), but I can't reproduce the problem you're reported (as I understood it).
Logged

JeffB

  • Senior Community Member
  • Posts: 326
  • Hero Points: 14
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #3 on: November 30, 2018, 03:48:38 PM »
vs doesn't seem to recognize that the file has been modified, so the buffer still shows the eol whitespace.  If you look at it outside of vs or close/re-open the file, you should be able to see it.
Logged

Dan

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2897
  • Hero Points: 153
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #4 on: November 30, 2018, 03:51:24 PM »
So the problem is that the EOL chars are not removed when saving in the diff?
Logged

JeffB

  • Senior Community Member
  • Posts: 326
  • Hero Points: 14
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #5 on: November 30, 2018, 03:53:23 PM »
no.  It removes the eol whitespace from lines I didn't actually modify.
Logged

Dan

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2897
  • Hero Points: 153
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #6 on: November 30, 2018, 03:59:41 PM »
Oh, I see it now.  This should be hotfixable, but it will not be a trivial fix.  I will start working on it.
Logged

JeffB

  • Senior Community Member
  • Posts: 326
  • Hero Points: 14
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #7 on: November 30, 2018, 04:10:08 PM »
Thanks, Dan!
Logged

Dan

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2897
  • Hero Points: 153
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #8 on: December 04, 2018, 02:50:38 PM »
I'm sorry, this is going to be a 23.0.1 fix.  It's taken me down quite a rabbit hole.
Logged

JeffB

  • Senior Community Member
  • Posts: 326
  • Hero Points: 14
Re: Files saved in DiffZilla not honoring "strip trailing spaces" setting
« Reply #9 on: December 04, 2018, 03:50:38 PM »
No worries...thanks for the update.
Logged
Pages: [1]   Go Up
« previous next »