problem with auto-creating C/C++ compiler tagfile

[hs2]

@SlickTeam: I found a bug in v12.0.3 when auto creating C/C++ compiler tagfiles. Some compiler 'header' files with non-standard extensions were not included in the compiler tagfile although specified in the 'C/C++ Files' file filter and set as 'C/C++' file type.
I've cross checked with v13.0.1 and as I've seen the issue is fixed in 'autotag.e' but not in 'refactor.e'.
refactor.e - refactor_build_compiler_tagfile() [line 6291]: SE v13.0.1 r20

Code: [Select]

      int i=pos('C/C++ Files',def_file_types,1,'r'_fpos_case);should be:

Code: [Select]

      int i=pos('C/C[+][+] Files',def_file_types,1,'r'_fpos_case);   // HS2-CHG: '+' -> '[+]'
Please verify this and all other occurences of C/C++ Files as regex search pattern and add this and maybe other fixes to v13.0.2.
I think there are a few more corrections needed...
Thanks, HS2

[hs2]

I've missed to add that the mouse wheel is not (longer) supported when trying to scroll the list of member files of a selected tagfile in the 'Tag Files' dialog. Dunno when it stopped working, but it's working in v12.0.3.
HS2

[chrisant]

Thanks, HS2.  In general when escaping a single character I prefer to use "\+" (literal notation) rather than "[ + ]" (set notation -- spaces added because otherwise the forum interprets it as a bullet mark) for slight performance improvement (not that perf matters in the cases we're talking about here).

There appears to be a similar problem in caddmem.e and codehelputil.e:

Code: [Select]

      parse def_file_types with '(^|,)C/C++ Files \(','ri' wildcards')';
Those two plus the one HS2 pointed out are the only ones I found by grepping the macros\*.e files for "C/C++".

[hs2]

That's what I've found too. But maybe there are more occurences in v13.0.2 alpha
Seems to me that the 'r' option could be just omitted. I can't see the need searching a bare string as regex pattern (that's my fix for v12.0.3 before I've checked v13)
However, I'm sure the SlickTeam knows the preferable way...

HS2