Author Topic: DEL in multi-line comments broken in v11.02  (Read 6668 times)

hs2

  • Senior Community Member
  • Posts: 2744
  • Hero Points: 288
DEL in multi-line comments broken in v11.02
« on: September 18, 2006, 01:04:25 pm »
Hello Slickteam,

maybe another part of the comment wrap story ;)
Try this example (e.g. w/ lang='e') w/ checked 'Enable line comment wrap':
Code: [Select]
   // <cursor here + hit DEL>dummy multi-line comment 1
   // dummy multi-line comment 2

I recognized that 2 chars are deleted

Can someone confirm that's in the standard product ?
Maybe it's caused by my own (buggy) customizations, but I don't think so in this case.
(seems that CW_maybeMerge() has a problem)

HS2
« Last Edit: September 19, 2006, 10:50:58 am by hs2 »

Graeme

  • Senior Community Member
  • Posts: 2443
  • Hero Points: 322
Re: DEL in multi-line comments broken in v11.02
« Reply #1 on: September 19, 2006, 09:12:11 am »

I can confirm the 2 characters being deleted when only one should be.  I can't see a problem with the line wrapping -  maybe you could post a specific example of how the line wrap goes wrong.

Graeme

hs2

  • Senior Community Member
  • Posts: 2744
  • Hero Points: 288
Re: DEL in multi-line comments broken in v11.02
« Reply #2 on: September 19, 2006, 09:40:05 am »
You are right Graeme. An example tells more than 100 words ...

Here we go:
before:
Code: [Select]
   // <cursor here + hit DEL>dummy multi-line comment 1
   // dummy multi-line comment 2

after (DEL):
Code: [Select]
   // <cursor here>mmy multi-line comment 1 dummy multi-line comment 2

@see my file ext setup attached

HS2
« Last Edit: September 19, 2006, 10:51:37 am by hs2 »

Graeme

  • Senior Community Member
  • Posts: 2443
  • Hero Points: 322
Re: DEL in multi-line comments broken in v11.02
« Reply #3 on: September 19, 2006, 10:03:57 am »

Ok, it wraps the two lines into one and deletes 'du' instead of just 'd' but the bit I didn't follow was why you think the wrapping is wrong  - with 'fixed right margin 96' the two lines can merge into one because the rightmost char is then at col 58.  Do you mean it should leave the second line alone and not wrap it back? 

I think it's around 6 a.m. in eastern U.S.A right now so slickteam are probably sound asleep  :)

Graeme

jbezem

  • Community Member
  • Posts: 84
  • Hero Points: 8
Re: DEL in multi-line comments broken in v11.02
« Reply #4 on: September 19, 2006, 10:15:47 am »
I wonder that the Slickteam didn't respond yet. It's a clear bug making the 'line comment wrap' feature almost useless...

Easy does it! 8)
Depending on when they noticed your initial post, and when they've distributed the tasks, you've hardly given them one working day to react. And I suppose they're still sleeping at the moment.
I know it's a nuisance, and from other posts we know that they know already.
From my point of view, the amount of real support given here in the forum is really great. I know no other company where employees spend so much time on support issues in an open forum.

And, thanks, of course, go to you and the many other users offering their experience to others. Several times your contributions have made a difference for me.

But even if turnaround times are usually far less than a day, be patient if that statistic is occasionally deteriorated.

Cheers,

Johan


hs2

  • Senior Community Member
  • Posts: 2744
  • Hero Points: 288
Re: DEL in multi-line comments broken in v11.02
« Reply #5 on: September 19, 2006, 10:49:56 am »
Uups - I made 2 big mistakes at once  :o
I afraid that my holidays were too short :(
@Graeme: You are right. Wrapping is absolutely ok here. I still didn't get used to the comment warp feature ...
+ @Johan: I totally missed the timezones.
And right - the forum provides superior support.
I really don't want to criticize the great Slickteam !

I've to admit that patience is not my strong point ;)

I'll correct my original posts - hopefully they are still sleeping well and didn't read it yet ...

HS2
« Last Edit: September 19, 2006, 10:56:04 am by hs2 »

hs2

  • Senior Community Member
  • Posts: 2744
  • Hero Points: 288
Re: DEL in multi-line comments broken in v11.02
« Reply #6 on: September 19, 2006, 11:33:07 am »
I think I found the problem (had a look at it impatient as I am).
This call to maybe_delete_tab() should also be commented out, right ?

commentformat.e [Revision: 1.140.2.16 - Slick v11.02] - CW_doDelete() [line 827]:
Code: [Select]
   if (p_line == startLine) {
      //If no content, let linewrap_delete_char() handle it.
      //DOB
      if (!CW_commentSettings.firstline_is_top) {
         return (false);
      }
      //If deleting left of the margin.  Behavior is undefined, so do nothing
      if (p_col <= CW_commentMarginLeftColStart) {
         return (false);
      }
      // HS2: commented - causes deletion of 2 chars
      // maybe_delete_tab();
   }

I did some testing and seems to work.

HS2

David_O

  • Senior Community Member
  • Posts: 152
  • Hero Points: 8
Re: DEL in multi-line comments broken in v11.02
« Reply #7 on: September 19, 2006, 04:04:17 pm »
Yes this was a bug that we caught a short while ago.  A hotfix was in the process of being creating when this thread began and should now be available.  The solution you identify is essentially what the hotfix does, though the hot fix also makes a few other very minor changes.

The bug caused the Delete to remove two characters when pressed on the first line of a multi-line comment.


hs2

  • Senior Community Member
  • Posts: 2744
  • Hero Points: 288
Re: DEL in multi-line comments broken in v11.02
« Reply #8 on: September 19, 2006, 05:20:44 pm »
Good news - so now it's time to try the new hotfix install feature ...
...
How do I get hotfixes ?
From website as described in the readme ? I can't find anything there :(

HS2