Author Topic: Problem finding correct class through std::unique_ptr<class>  (Read 1557 times)

rowbearto

  • Senior Community Member
  • Posts: 1481
  • Hero Points: 112
Problem finding correct class through std::unique_ptr<class>
« on: August 21, 2019, 01:20:38 am »
This is an issue in v23.0.2 as well as in v24 beta2.

Look for whichclass.tar.gz on support.

Inside the README file are instructions to reproduce.

I'm using Linux x64, Centos 7.2, system gcc is 4.8.2, Slickedit v23.0.2.

FYI: The "ccls" code browser is able to do this correctly: https://github.com/MaskRay/ccls
« Last Edit: August 21, 2019, 01:40:44 am by rowbearto »

Dennis

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2811
  • Hero Points: 425
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #1 on: September 04, 2019, 05:16:44 pm »
Reproduced and looking into it.

Dennis

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2811
  • Hero Points: 425
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #2 on: September 05, 2019, 04:33:33 pm »
This will be fixed in the next build for v24.

rowbearto

  • Senior Community Member
  • Posts: 1481
  • Hero Points: 112
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #3 on: September 05, 2019, 05:14:33 pm »
Thanks Dennis!

rowbearto

  • Senior Community Member
  • Posts: 1481
  • Hero Points: 112
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #4 on: September 06, 2019, 02:28:56 am »
Dennis: Did you test it with both types of unique_ptr/UniquePtr that I had in the sample project?

Dennis

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2811
  • Hero Points: 425
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #5 on: September 06, 2019, 02:41:35 pm »
I started down that path, but then stopped when I observed that UniquePtr was a wrapper for std::unique_ptr<>

rowbearto

  • Senior Community Member
  • Posts: 1481
  • Hero Points: 112
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #6 on: September 06, 2019, 02:43:49 pm »
Hmm, so not sure I understand. Our production code uses the UniquePtr instead of unique_ptr.

So will I have this issue using UniquePtr in my code instead of unique_ptr?

Can you verify your fix works also with UniquePtr, even though it is a wrapper can Slick handle the way the wrapper is done?
« Last Edit: September 06, 2019, 02:47:15 pm by rowbearto »

Dennis

  • SlickEdit Team Member
  • Senior Community Member
  • *
  • Posts: 2811
  • Hero Points: 425
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #7 on: September 06, 2019, 05:20:41 pm »
I looked at it again and checked in a few more fixes for the next beta.  Works with your UniquePtr class now (or std::unique_ptr).

rowbearto

  • Senior Community Member
  • Posts: 1481
  • Hero Points: 112
Re: Problem finding correct class through std::unique_ptr<class>
« Reply #8 on: September 06, 2019, 05:25:06 pm »
Thanks Dennis!