Author Topic: Quick Refactor is a bit overreaching  (Read 2855 times)

mark0978

  • Community Member
  • Posts: 98
  • Hero Points: -2
Quick Refactor is a bit overreaching
« on: March 17, 2010, 10:01:24 PM »
Beta 2:
Quick Refactor | Rename of filename rummages thru all the source in the project and includes (including Boost headers) and comes up with a huge list of changes to make.

filename is a LOCAL variable, refactor is a LOCAL operation on a LOCAL variable!


Code: [Select]
void TestDirExists() {

std::string filename(m_strFilename);
filename += '/';

CPPUNIT_ASSERT(IHawk::DirExists(NULL) == false);
CPPUNIT_ASSERT(IHawk::DirExists("/"));

CPPUNIT_ASSERT(IHawk::DirExists(filename.c_str()) == false);
CPPUNIT_ASSERT(IHawk::DirExists(m_strFilename.c_str()) == false);
CPPUNIT_ASSERT(_mkdir(m_strFilename.c_str()) == 0);
CPPUNIT_ASSERT(IHawk::DirExists(filename.c_str()));
CPPUNIT_ASSERT(_rmdir(m_strFilename.c_str()) == 0);
CPPUNIT_ASSERT(IHawk::DirExists(filename.c_str()) == false);
std::ofstream out;
out.open(m_strFilename.c_str());
out.close();
CPPUNIT_ASSERT(IHawk::DirExists(m_strFilename.c_str()) == false);
}